Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alpha specific app groups #1934

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Add alpha specific app groups #1934

merged 1 commit into from
Aug 23, 2023

Conversation

graeme
Copy link
Contributor

@graeme graeme commented Aug 23, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1205332058642473/f

Description:

This is needed to fix a potential problem when running the prod + Alpha builds side by side. If we don’t separate the app groups, we would end up sharing state between the two which could introduce problems when we change schema between releases.

Steps to test this PR:

  1. Check out the branch
  2. Go to the Project view, select target from DuckDuckGo, WidgetsExtension and PacketTunnelProvider, select Signing & Capabilities for each and, in their Alpha config ensure that you have the Provisioning Profiles downloaded.
  3. If step 2 fails, open the Terminal, make sure you’re in the iOS repo, and run bundle exec fastlane sync_signing_alpha then repeat step 2.
  4. Go to Schemes and change the Archive setting to build the Alpha
  5. Generate an Archive (Product → Archive)
  6. When the Organizer shows (or, if it doesn’t, but the build succeeded, open it manually) select the most recent archive and hit Validate App. Note: you are not going to complete this flow!!
  7. Go through the whole flow (selecting profiles along the way).
  8. Once you get to the final Summary stage, there will be a list of app groups. Make sure they all have the format group.com.duckduckgo.alpha.*

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@graeme graeme requested review from diegoreymendez and samsymons and removed request for diegoreymendez August 23, 2023 13:28
@graeme graeme mentioned this pull request Aug 23, 2023
Merged
13 tasks
samsymons
samsymons approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@samsymons samsymons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, testing steps worked as expected, and I'm still able to build the regular app for both debug and release. App groups look good!

@graeme graeme merged commit 71763ff into develop Aug 23, 2023
11 of 12 checks passed
@graeme graeme deleted the graeme/add-alpha-app-groups branch August 23, 2023 15:33
samsymons added a commit that referenced this pull request Aug 24, 2023
@samsymons
Merge branch 'develop' into sam/codeql-support
e59c6ec 
* develop: (84 commits)
  Improve Sync-related database cleaning logic (#1933)
  Fix PacketTunnelProvider embedding for Alpha builds (#1932)
  Add alpha specific app groups (#1934)
  Replaces useSystemKeychain with keychain type (#1928)
  Add Commit hook install script (#1845)
  Run checks on all PRs (#1929)
  extend valid urls to include IPv6 (#1919)
  Status view error UI (#1915)
  NetP Design Review minus errors (#1923)
  Add a GHA job to build the app in release configuration (#1848)
  Release 7.85.0 (#1926)
  Update WireGuard version (#1918)
  BSK Hotfix 74.0.1-1 (#1924)
  Post merge PR check (#1920)
  Autofill letter icons for macOS (#1911)
  Alpha build readiness (#1913)
  bump C-S-S to 4.32.0 (#1914)
  Update NetP endpoint (#1905)
  Network Protection debug menu (#1910)
  Add support for syncing Credentials (#1844)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsymons samsymons samsymons approved these changes

Assignees

@graeme graeme

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@graeme @samsymons